Fix a bunch of rubocop offenses

.rubocop_todo.yml

@@ -1,73 +1,11 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config`
-# on 2020-03-09 13:28:58 +0100 using RuboCop version 0.80.1.
+# on 2020-03-09 14:56:53 +0100 using RuboCop version 0.80.1.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
 # versions of RuboCop, may require this file to be generated again.
 
-# Offense count: 1
-# Cop supports --auto-correct.
-Layout/EmptyLineAfterGuardClause:
-  Exclude:
-    - 'lib/parseable_date_validator.rb'
-
-# Offense count: 1
-# Cop supports --auto-correct.
-Layout/EmptyLines:
-  Exclude:
-    - 'config/application.rb'
-
-# Offense count: 3
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle.
-# SupportedStyles: empty_lines, no_empty_lines
-Layout/EmptyLinesAroundBlockBody:
-  Exclude:
-    - 'config/environments/development.rb'
-    - 'db/schema.rb'
-
-# Offense count: 3
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle.
-# SupportedStyles: empty_lines, empty_lines_except_namespace, empty_lines_special, no_empty_lines, beginning_only, ending_only
-Layout/EmptyLinesAroundClassBody:
-  Exclude:
-    - 'config/application.rb'
-    - 'lib/parseable_date_validator.rb'
-
-# Offense count: 1
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyleAlignWith, AutoCorrect, Severity.
-# SupportedStylesAlignWith: keyword, variable, start_of_line
-Layout/EndAlignment:
-  Exclude:
-    - 'app/views/search/index.rss.builder'
-
-# Offense count: 2
-# Cop supports --auto-correct.
-# Configuration parameters: AllowForAlignment, AllowBeforeTrailingComments, ForceEqualSignAlignment.
-Layout/ExtraSpacing:
-  Exclude:
-    - 'bin/rails'
-    - 'config.ru'
-
-# Offense count: 1
-# Cop supports --auto-correct.
-# Configuration parameters: AllowDoxygenCommentStyle, AllowGemfileRubyComment.
-Layout/LeadingCommentSpace:
-  Exclude:
-    - 'config/application.rb'
-
-# Offense count: 2
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle.
-# SupportedStyles: final_newline, final_blank_line
-Layout/TrailingEmptyLines:
-  Exclude:
-    - 'config/initializers/assets.rb'
-    - 'config/initializers/cookies_serializer.rb'
-
 # Offense count: 1
 Lint/InterpolationCheck:
   Exclude:
@@ -79,32 +17,11 @@ Lint/SendWithMixinArgument:
   Exclude:
     - 'config/initializers/kaminari_config.rb'
 
-# Offense count: 3
-# Configuration parameters: AllowComments.
-Lint/SuppressedException:
-  Exclude:
-    - 'bin/rails'
-    - 'bin/rake'
-    - 'bin/rspec'
-
-# Offense count: 1
-# Cop supports --auto-correct.
-# Configuration parameters: AllowUnusedKeywordArguments, IgnoreEmptyMethods.
-Lint/UnusedMethodArgument:
-  Exclude:
-    - 'lib/parseable_date_validator.rb'
-
-# Offense count: 2
-Lint/UselessAssignment:
-  Exclude:
-    - 'lib/parseable_date_validator.rb'
-    - 'spec/features/basic_search_spec.rb'
-
 # Offense count: 4
 Metrics/AbcSize:
   Max: 58
 
-# Offense count: 9
+# Offense count: 8
 # Configuration parameters: CountComments, ExcludedMethods.
 # ExcludedMethods: refine
 Metrics/BlockLength:
@@ -137,124 +54,18 @@ Naming/VariableNumber:
   Exclude:
     - 'spec/features/search_filters_spec.rb'
 
-# Offense count: 15
-Style/Documentation:
-  Exclude:
-    - 'spec/**/*'
-    - 'test/**/*'
-    - 'app/controllers/application_controller.rb'
-    - 'app/controllers/geo_controller.rb'
-    - 'app/controllers/import_controller.rb'
-    - 'app/controllers/search_controller.rb'
-    - 'app/helpers/search_helper.rb'
-    - 'app/models/importer.rb'
-    - 'app/models/paper.rb'
-    - 'app/models/paper_search.rb'
-    - 'app/models/user.rb'
-    - 'config/application.rb'
-    - 'db/migrate/20141117201926_create_users.rb'
-    - 'db/migrate/20150413193656_create_papers.rb'
-    - 'db/migrate/20150517152218_create_importers.rb'
-    - 'db/migrate/20151010070158_create_paper_searches.rb'
-    - 'lib/parseable_date_validator.rb'
-
 # Offense count: 1
 Style/DoubleNegation:
   Exclude:
     - 'app/controllers/application_controller.rb'
 
-# Offense count: 9
-# Cop supports --auto-correct.
-Style/ExpandPathArguments:
-  Exclude:
-    - 'Rakefile'
-    - 'bin/bundle'
-    - 'bin/rails'
-    - 'bin/rake'
-    - 'bin/rspec'
-    - 'config/application.rb'
-    - 'config/boot.rb'
-    - 'config/environment.rb'
-
-# Offense count: 34
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle.
-# SupportedStyles: always, always_true, never
-Style/FrozenStringLiteralComment:
-  Enabled: false
-
-# Offense count: 1
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, UseHashRocketsWithSymbolValues, PreferHashRocketsForNonAlnumEndingSymbols.
-# SupportedStyles: ruby19, hash_rockets, no_mixed_keys, ruby19_no_mixed_keys
-Style/HashSyntax:
-  Exclude:
-    - 'config/routes.rb'
-
-# Offense count: 7
-# Cop supports --auto-correct.
-Style/IfUnlessModifier:
-  Exclude:
-    - 'app/models/paper_search.rb'
-    - 'app/views/search/index.rss.builder'
-    - 'spec/rails_helper.rb'
-
-# Offense count: 5
-# Cop supports --auto-correct.
-# Configuration parameters: .
-# SupportedStyles: call, braces
-Style/LambdaCall:
-  EnforcedStyle: braces
-
 # Offense count: 2
 Style/MultilineTernaryOperator:
   Exclude:
     - 'app/controllers/search_controller.rb'
     - 'spec/features/basic_search_spec.rb'
 
-# Offense count: 1
-# Cop supports --auto-correct.
-# Configuration parameters: Strict.
-Style/NumericLiterals:
-  MinDigits: 15
-
-# Offense count: 1
-# Cop supports --auto-correct.
-# Configuration parameters: PreferredDelimiters.
-Style/PercentLiteralDelimiters:
-  Exclude:
-    - 'Guardfile'
-
-# Offense count: 45
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, ConsistentQuotesInMultiline.
-# SupportedStyles: single_quotes, double_quotes
-Style/StringLiterals:
-  Exclude:
-    - 'Guardfile'
-    - 'bin/rails'
-    - 'bin/rake'
-    - 'bin/rspec'
-    - 'db/schema.rb'
-    - 'lib/parseable_date_validator.rb'
-    - 'lib/tasks/import_papers.rake'
-
-# Offense count: 1
-# Cop supports --auto-correct.
-# Configuration parameters: MinSize.
-# SupportedStyles: percent, brackets
-Style/SymbolArray:
-  EnforcedStyle: brackets
-
-# Offense count: 1
-# Cop supports --auto-correct.
-# Configuration parameters: WordRegex.
-# SupportedStyles: percent, brackets
-Style/WordArray:
-  EnforcedStyle: percent
-  MinSize: 3
-
-# Offense count: 63
+# Offense count: 57
 # Cop supports --auto-correct.
 # Configuration parameters: AutoCorrect, AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns.
 # URISchemes: http, https